Skip to content

Bump version of glfw.#977

Merged
jdumas merged 2 commits intolibigl:devfrom
jdumas:glfw
Nov 6, 2018
Merged

Bump version of glfw.#977
jdumas merged 2 commits intolibigl:devfrom
jdumas:glfw

Conversation

@jdumas
Copy link
Copy Markdown
Collaborator

@jdumas jdumas commented Oct 24, 2018

Current version of glfw produces the following warning with recent versions of CMake:

CMake Deprecation Warning at external/glfw/CMakeLists.txt:10 (cmake_policy):
  The OLD behavior for policy CMP0042 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.

The new version has CMake 3.0 as minimum version instead of 2.8.12, but that's ok since our CMake requires 3.1.

Check all that apply (change to [x])

fwilliams
fwilliams approved these changes Oct 24, 2018
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fwilliams fwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests pass and you can manually verify the viewer works, I approve. Can somebody else also check that the change doesn't break Mac and Windows?

@fwilliams
Copy link
Copy Markdown
Collaborator

fwilliams commented Oct 24, 2018

This is totally orthogonal, but does this fix the transparency issue on Mac that @teseoch was working on?

@fwilliams fwilliams requested a review from teseoch October 24, 2018 15:35
@jdumas
Copy link
Copy Markdown
Collaborator Author

jdumas commented Oct 24, 2018 •
edited
Loading

No this the issue is still open in GLFW (see here and there). What teseo pushed is a less hacky fix that doesn't involve messing up the transparency or moving the window.

@jdumas
Copy link
Copy Markdown
Collaborator Author

jdumas commented Oct 24, 2018

Argh of course it fails to build on Windows =( (but glfw has CI on Windows, so we may be missing something).

@jdumas
Copy link
Copy Markdown
Collaborator Author

jdumas commented Nov 5, 2018

Updated again so the compilation bug on Windows is fixed. Anybody on macOS can confirm there's no trouble with the viewer so we can merge? (@teseoch with the multiple dpi?).

teseoch
teseoch approved these changes Nov 6, 2018
View reviewed changes
Copy link
Copy Markdown
Collaborator

@teseoch teseoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok the different dpi screens

@jdumas jdumas merged commit 1dce7f0 into libigl:dev Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teseoch teseoch teseoch approved these changes

+1 more reviewer

@fwilliams fwilliams fwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jdumas @fwilliams @teseoch