Skip to content

Macos Mojave different hack and Windows minimisation fix#953

Merged
teseoch merged 1 commit intolibigl:devfrom
teseoch:dev
Oct 23, 2018
Merged

Macos Mojave different hack and Windows minimisation fix#953
teseoch merged 1 commit intolibigl:devfrom
teseoch:dev

Conversation

@teseoch
Copy link
Copy Markdown
Collaborator

@teseoch teseoch commented Oct 18, 2018

changed hack for Mojave such that it is not running with transparency enabled
fixed a bug on windows when minimising the window.

Unfortunately not tested on windows

Check all that apply (change to [x])

  • All changes meet libigl style-guidelines.
  • Adds new .cpp file.
  • Adds corresponding unit test.
  • Adds corresponding python binding.
  • This is a minor change.

… fixed a bug on windows when iconizing the window
Copy link
Copy Markdown
Contributor

@alecjacobson alecjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@teseoch teseoch closed this Oct 19, 2018
@teseoch teseoch reopened this Oct 19, 2018
@teseoch teseoch merged commit 8d5533a into libigl:dev Oct 23, 2018
@teseoch teseoch deleted the dev branch October 23, 2018 15:56
@jdumas jdumas mentioned this pull request Oct 25, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants