Thanks @ikoruk , just FYI, we are in the process of migrating to Catch2 instead of google unit test.

This looks good. Is there a special way I'm suppose to mark this as reviewed?

I agree @qnzhou , but that looks like a separate PR to me.

@qnzhou We're going to need to fix that for the Python bindings. Is there an open issue?

Alternatively, @ikoruk could you maybe do this in your PR #947? If not, then no big deal, we'll end up doing it in the dev-python branch.

I discovered a bug in intersectBeam and issued a fix into this PR yesterday, so this should be re-reviewed before merging.

there is a script (posted on the other PR) to convert a google test into Catch2 test

I updated the test to catch2. @ikoruk can you check?

@teseoch The changes look fine to me but I haven't used catch, don't know what would make it skip tests on windows.

Alright, I managed to compile embree statically on Windows, the build on AppVeyor looks ok now!

As for why unit-tests were not showing on AppVeyor before, this has to do with the way Catch2 discovers unit tests and populates the CTest config. Indeed, the macro catch_discover_tests() will run internally ./igl_tests to get the list of available unit tests. Now, because of the new CMake setup, the executable igl_tests.exe was not finding the embree3.dll at runtime, and thus was not able to create the list of tests for CTest. Which is why igl_tests.exe was compiled correctly but no tests were found on AppVeyor. catch_discover_tests() interprets the return code of the unit test program as the number of tests to be defined (and then proceeds to parse the stdout). I don't have the energy to test this, but I suspect that a missing dll produces a return code > 0, which is why no error was reported by AppVeyor and no test was run.