Eigen build fix, Eigen::all has been renamed.#2399
Merged
alecjacobson merged 1 commit intolibigl:mainfrom Oct 28, 2024
Merged
Conversation
Replace deprecated/removed Eigen::all with Eigen::placeholders:all.
Contributor
|
Wait, what?? There isn't a short name like |
Collaborator
|
Apparently these names are too common: https://gitlab.com/libeigen/eigen/-/merge_requests/649 |
|
@mheistermann When using diff --git a/include/igl/copyleft/cgal/mesh_boolean.cpp b/include/igl/copyleft/cgal/mesh_boolean.cpp
index 02d7a1c1..1de7aed3 100644
--- a/include/igl/copyleft/cgal/mesh_boolean.cpp
+++ b/include/igl/copyleft/cgal/mesh_boolean.cpp
@@ -337,7 +337,7 @@ IGL_INLINE bool igl::copyleft::cgal::mesh_boolean(
const size_t num_selected = selected.size();
DerivedFC kept_faces(num_selected, 3);
- DerivedJ kept_face_indices(num_selected, 1);
+ VectorXJ kept_face_indices(num_selected);
for (size_t i=0; i<num_selected; i++)
{
size_t idx = abs(selected[i]) - 1;
@@ -348,7 +348,7 @@ IGL_INLINE bool igl::copyleft::cgal::mesh_boolean(
{
kept_faces.row(i) = F.row(idx).reverse();
}
- kept_face_indices(i, 0) = CJ[idx];
+ kept_face_indices(i) = CJ[idx];
}
#ifdef MESH_BOOLEAN_TIMING
log_time("extract_output");
@@ -357,7 +357,7 @@ IGL_INLINE bool igl::copyleft::cgal::mesh_boolean(
// Finally, remove duplicated faces and unreferenced vertices.
{
DerivedFC G;
- DerivedJ JJ;
+ VectorXJ JJ;
igl::resolve_duplicated_faces(kept_faces, G, JJ);
J = kept_face_indices(JJ); |
Contributor
|
lol. I guess this needed to also bump Eigen because with the old Eigen I get tons of warnings now.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the build for recent Eigen versions.
Eigen::allwas first deprecated and is now only available asEigen::placeholders:all.This commit is simply the result of a search-and-replace,
gsed -i 's/Eigen::all/Eigen::placeholders::all/' **/*(.)Checklist