Fix dqs not checking if quaternions are on the same hemisphere#2390
Merged
alecjacobson merged 2 commits intolibigl:mainfrom May 15, 2025
Merged
Fix dqs not checking if quaternions are on the same hemisphere#2390alecjacobson merged 2 commits intolibigl:mainfrom
alecjacobson merged 2 commits intolibigl:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dual quaternion skinning not checking if the quaternions are on the same hemisphere. For quaternions$q$ and $-q$ represents the same rotation.
One trivial example is when randomly negate one of the rotations in vQ in tutorial 404, the current implementaion yields unplausible result. It works in tutorial 404 because the input rotations happens to be on the same hemisphere, but this is not guaranteed in general. Similar check is also used in Blender for DQS here.
Checklist