Avoid conflicting template parameters in AABB#2256
Merged
alecjacobson merged 1 commit intomainfrom Aug 30, 2023
Merged
Conversation
Contributor
Author
|
If I can do this right, then I can get rid of this junk: Line 994 in 7a84503 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #436
This uses class template specialization to avoid ever calling AABB with conflicting template params (e.g., MatrixX3D and DIM=2). The old code was all dynamic so it lead to conflicting compilation paths.
I claim this is a reasonable C++11 solution. If we were using C++17 then we could use
if constexprwhich would be significantly less code and more readable.Unless I notice something broken with this, I'll also fix the nasty dynamic situation in
signed_distancesimilarly. And then we can add [to AABB] aSo that bogus compilation paths get caught.