Expose cutoff parameter for CGAL intersections; better default#2255
Merged
alecjacobson merged 2 commits intomainfrom Aug 29, 2023
Merged
Expose cutoff parameter for CGAL intersections; better default#2255alecjacobson merged 2 commits intomainfrom
alecjacobson merged 2 commits intomainfrom
Conversation
If you're curious, you can read about what this parameter is in Fast Software for Box Intersections. Basically it determines how early the algorithm switches from tree recursion to scanning. The authors do a bunch of experimentation with the parameter themselves. It's odd that CGAL chose 10 as the default since the paper seems to point toward values in the 1k-10k range as best, generally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #270
CGAL weirdly uses a pretty bad default for the somewhat mysterious
cutoffparameter in box_intersections_d and box_self_intersections_dI tired 1,10,100,1000,10000,100000 and √n for all the tutorial data models (not a particularly good test set) and 1000 was the clear winner.
So, this now uses that as the default and exposes the parameter for users to tweak if needed.
The speedups are modest (like 1.1-1.2x).