Adjust igl::boundary_conditions(...) to support 3D cages#2229
Merged
alecjacobson merged 7 commits intolibigl:mainfrom Aug 17, 2023
Merged
Adjust igl::boundary_conditions(...) to support 3D cages#2229alecjacobson merged 7 commits intolibigl:mainfrom
alecjacobson merged 7 commits intolibigl:mainfrom
Conversation
Contributor
|
Cool! That's great. I just had someone emailing about exactly this. So good timing. |
Contributor
Author
|
I cannot reproduce the build error on a windows machine setting static=off, tests=off and tutorials=ON. Also I did not include any additional includes or anything else related to heap space. Are there some troubles with not enough memory available on the machine? |
Contributor
|
yes, that's a frequent issue with the github actions on windows. We just need to rerun and hope it succeeds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
In order to support cage-based deformations using 3D cages, the igl::boundary_conditions(...) function needs to support (triangular) cage faces. This is a fix to add support of 3D cages to libigl. In previous projects e.g. #110 libigl was lacking a function to calculate the boundary conditions for 3D cages. So, developers needed to implement this themselves. With this fix, libigl's igl::boundary_conditions(...) is capable of 3D cages.
The new version of igl::boundary_conditions(...) has been extensively tested in a TU Darmstadt/Fraunhofer IGD project using igl::bbw or igl::harmonic (and even more). The build was tested using GCC 11.3. The tests for libigl core completed flawlessly.
Checklist