Skip to content

Add missing <cstdint> header for gcc 13#2192

Merged
alecjacobson merged 1 commit intolibigl:mainfrom
topazus:main
Apr 20, 2023
Merged

Add missing <cstdint> header for gcc 13#2192
alecjacobson merged 1 commit intolibigl:mainfrom
topazus:main

Conversation

@topazus
Copy link
Copy Markdown
Contributor

@topazus topazus commented Apr 18, 2023

Fixes # .

Added missing headers in order to fix build with GCC 13.
ref: https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes

Checklist

  • All changes meet libigl style-guidelines.
  • Adds new .cpp file.
  • Adds corresponding unit test.
  • This is a minor change.

@BruegelN
Copy link
Copy Markdown
Contributor

I can confirm the issue with gcc13 and this PR resolves it.
The failed windows CI jobs isn't related to these changes.

@alecjacobson
Copy link
Copy Markdown
Contributor

yeah, it's just stupid heap space issue. I wish we had a solution for it. Like deleting/testing stuff as we go. I'm rerunning it but anyway it will rerun (and possible fail again and need rerunning on merge). So I'm merging. Thanks!

@alecjacobson alecjacobson reopened this Apr 20, 2023
@alecjacobson alecjacobson merged commit 7b6cc27 into libigl:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants