Skip to content

Fix CMake package installation for igl_core#2188

Merged
alecjacobson merged 1 commit intolibigl:mainfrom
FabienPean:patch-3
Jun 26, 2023
Merged

Fix CMake package installation for igl_core#2188
alecjacobson merged 1 commit intolibigl:mainfrom
FabienPean:patch-3

Conversation

@FabienPean
Copy link
Copy Markdown
Contributor

Fixes #2186 (or a part of it)

Fix the packaging of igl so that the core library is correctly found. Tested on WSL-Ubuntu-20.04 with GCC 9.4.0.

find_package(libigl CONFIG REQUIRED)
target_link_libraries(main PUBLIC igl::igl_core)

Checklist

  • All changes meet libigl style-guidelines.
  • Adds new .cpp file.
  • Adds corresponding unit test.
  • This is a minor change.

@alecjacobson
Copy link
Copy Markdown
Contributor

I don't have the cmake expertise to know if this would mess anything else up. Hopefully, @jdumas could give a quick review.

@alecjacobson alecjacobson requested a review from jdumas June 26, 2023 14:57
Copy link
Copy Markdown
Collaborator

@jdumas jdumas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@alecjacobson alecjacobson merged commit afafc7c into libigl:main Jun 26, 2023
@FabienPean FabienPean deleted the patch-3 branch June 26, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v2.4.0 top-level CMake installation is broken

3 participants