Merged
Conversation
Contributor
Author
|
huh. Well it didn't really speed up the slow one... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hope is that now that the build is more split up after #2165 we can restore #2161 . I think there's a theory that the "out of heap space" errors are when two threads are using a ton of memory at the same time. If that's the case, the simple split of tests and tutorial won't necessarily change. I think I roughly know which units take tons of memory (in the header only it's usually the CGAL module ones). So I guess a further idea would be to see if we can force CMAKE to be serial for just those.
Maybe an even better option would be to see if we can use https://docs.github.com/en/actions/hosting-your-own-runners/about-self-hosted-runners