Merged
Conversation
Contributor
Author
|
huh. It's still failing. I guess I don't understand what's being run when. Is it failing on |
Contributor
Author
|
Ok, so after a bunch of experiments, it seems like the easiest fix is to just avoid running The other PR is trying to download a ccache binary. But even if that works it seems inferior to using a package manager in some respects. |
Contributor
Author
|
I'm going to go ahead and merge this for now so our CI continues. If I can grab @jdumas 's ear at some point maybe we can do something better. |
Collaborator
|
I think this solution is as good as any tbh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is failing because I think
brew updateis sending a failing exit code. https://github.com/libigl/libigl/actions/runs/3832188849/jobs/6522212468It seems everything is continuing to install fine but it doesn't like that it can't create python links (which I don't believe we're using).
This fix (suggested here) just forces the update to return true. It seems that many others just run
brew install ccachewithoutbrew update. Not sure if we still needbrew updateor if that was from when we used brew to get gmp and mpfr.Another option would be to install ccache in some more reproducible way, but I don't have the bandwidth to figure that out at the moment.