glfw viewer - high dpi: handling both width and height.#2117
Merged
alecjacobson merged 1 commit intolibigl:mainfrom Feb 4, 2023
fghoussen:highdpi
Merged
glfw viewer - high dpi: handling both width and height.#2117alecjacobson merged 1 commit intolibigl:mainfrom fghoussen:highdpi
alecjacobson merged 1 commit intolibigl:mainfrom
fghoussen:highdpi
Conversation
Contributor
|
Is this fixing a known issue or something that theoretically could happen? Wouldn't that mean that someone's display has a different resolution in height vs width? |
Contributor
Author
|
I have not the HW to test this, so, I can not say this has been tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
From what I know of OpenGL, both width and height must be handled to resize window to frame.
Not 100% sure!...I PR that as a proposal: I let you decide if it's a good move
Checklist
make all testruns OK at my side (debian)