Improve robustness of ICP solve when closest points and normals are degenerate#2107
Merged
alecjacobson merged 4 commits intomainfrom Jan 20, 2023
Merged
Improve robustness of ICP solve when closest points and normals are degenerate#2107alecjacobson merged 4 commits intomainfrom
alecjacobson merged 4 commits intomainfrom
Conversation
|
Do you have any plans to add colored ICP like in open3d? |
Contributor
Author
|
No plans but would be happy to merge a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From slack:
Archive.zip
This change switches ldlt (cholesky) for rank-revealing qr. If the rank is too low, then a weight is increased on a point-to-point regularization term.