Tetgen: fix bug when faces don't have markers#2069
Merged
alecjacobson merged 1 commit intomainfrom Aug 15, 2022
Merged
Conversation
Collaborator
|
Looks good to me. I have no clue about the reason for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure why this
ifwas here in the first place. This function doesn't extract markers. (seems either qnzhou or daneielpanozzo wrote the original line). Before this fix, if the face list existed but markers did not, then it would crash. Now, it ignores the possibility of markers and extracts existing faces.(Properly extracting markers is left for a future PR).