Fixes a race condition in the dual contouring code.#2045
Merged
alecjacobson merged 1 commit intolibigl:mainfrom Jun 4, 2022
Merged
Fixes a race condition in the dual contouring code.#2045alecjacobson merged 1 commit intolibigl:mainfrom
alecjacobson merged 1 commit intolibigl:mainfrom
Conversation
The previous version of the code would call new_vertex() outside of the mutex, which would trigger a call to resize some std::vector<>s. This addresses the issue by moving the vertex such that the initialization of ev is contained within the mutex.
Contributor
|
lgtm, will wait for the CI to finish just in case. |
Contributor
Author
|
Alec: gentle reminder to finish reviewing this guy. Thanks! |
alecjacobson
approved these changes
Jun 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version of the code would call new_vertex() outside of the mutex right below it, which would in turn trigger a call to resize a bunch of std::vector<>s. The patch addresses the issue by moving the vertex such that the initialization of ev is contained within the mutex.
Fixes #2044.
Tested by meshing a handful of signed distance fields created using Chris Batty's SDF generator.
Checklist