Avoid converting exact input to inexact when detecting intersections#2019
Merged
alecjacobson merged 6 commits intomainfrom Mar 30, 2022
Merged
Avoid converting exact input to inexact when detecting intersections#2019alecjacobson merged 6 commits intomainfrom
alecjacobson merged 6 commits intomainfrom
Conversation
Contributor
Author
|
Added unit test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous
remesh_self_intersections.cppandintersect_other.cpphad a branchThis only depended on the boolean flag
detect_only. Unfortunately, that meant if the caller's input vertices were in the exact typeCGAL::Epeck::FTanddetect_only=true, then the input would be converted (i.e., rounded) toCGAL::Epick::FT(akadouble) before looking for intersections. This leads to false positives.This PR replaces the branch with
if detect_only and not Epeck input.Hopefully this merges easily so I can get it in before finishing #1539 1895