Skip to content

remove Eigen::DynamicSparseMatrix and fix bug in sparse igl::slice_into#2016

Merged
alecjacobson merged 1 commit intomainfrom
alecjacobson/rm-DynamicSparseMatrix
Mar 27, 2022
Merged

remove Eigen::DynamicSparseMatrix and fix bug in sparse igl::slice_into#2016
alecjacobson merged 1 commit intomainfrom
alecjacobson/rm-DynamicSparseMatrix

Conversation

@alecjacobson
Copy link
Copy Markdown
Contributor

This removes all remaining uses of Eigen::DynamicSparseMatrix, which has been deprecated in Eigen for a while.

  • removes unreachable code with comment summary of performance comparison in cat.cpp
  • removes commented code in diag.cpp
  • replaces Eigen::DynamicSparseMatrix with setFromTriplets in diag.cpp
  • adds a unit test for igl::diag
  • previous slice_into was buggy for sparse inputs ( 🤯 ): adds a unit test and fixes sparse overload (replacing Eigen::DynamicSparseMatrix with use of SparseVector and innerIterators)

@alecjacobson alecjacobson merged commit 7174a7a into main Mar 27, 2022
@alecjacobson alecjacobson deleted the alecjacobson/rm-DynamicSparseMatrix branch March 27, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant