Merged
Conversation
Collaborator
|
FYI I have updated the github action stuff to fix the windows issues. You may want to update your PRs to merge with the main branch. |
Contributor
Author
|
What can we do about this static build on windows? It's always running out of heap space... |
Collaborator
|
It could be that even with our separate job pools, ninja may be running two parallel jobs (1 compilation + 1 link) at the same time. I've opened #2018 to limit global parallelism with ninja, let's see if it helps. |
Contributor
Author
|
I'm starting to wonder if the bump in eigen is somehow exacerbating the Windows CI issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1974
We've just released our v2.4 so now is a good time to bump eigen and get a lot of testing in before our next release. I'm particularly worried about performance gotchas that might be hard to catch. There are also probably plenty of new features of Eigen v3.4.0 that we could refactor current libigl functions to take advantage of.