Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous
ViewerCore::draw_bufferonly draw a single ViewerData entry (suprise! only one mesh got drawn) and the caller had to specify the size when often they just wanted the current viewport size.This PR sets the size to the viewport if it's passed as empty and adds a
Viewer::draw_bufferroutine that will draw an entireViewerCore. TheViewerCore::draw_bufferis left in place but should probably be removed in the future. I could imagine wanting to draw multiple cores, leaving that for a future PR to refactor this further.The new
Viewer::draw_bufferalso writes depth images and templates the output type the caller can get higher precision images, too.