Remove hardcoded ImGui menu width constraint#1991
Merged
alecjacobson merged 1 commit intolibigl:mainfrom Mar 14, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ImGuiMenuclass currently constraints the width to a hardcoded value, and also enables auto-resizing. Both of these settings overlap, in that they both prevent the user from resizing the ImGui menu, but the width constraint effectively overrides the auto-resizing feature, which sets the width at a potentially undesirable value (e.g., wide content can be truncated). Removing the width constraint and just letting ImGui resize the menu automatically seems to be a good approach. I've only tested this on some code in a private repo that I don't want to share publicly, but I am happy to write up a simple example demonstrating the change, or discuss an alternative approach (e.g., perhaps a user might want to set a maximum width constraint or manually fix the width on their end).Checklist