Patch FastWindingNumberForSoups.h to compile without SSE (i.e., on M1 macs) #1975
Merged
alecjacobson merged 1 commit intomainfrom Feb 18, 2022
Merged
Patch FastWindingNumberForSoups.h to compile without SSE (i.e., on M1 macs) #1975alecjacobson merged 1 commit intomainfrom
alecjacobson merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue directly cited in #1686 so now the igl_core compiles on arm64 (but I think embree also needs to be bumped).
This is a rather hot fix. In the long run, we should consider embracing TBB and a more elegant solution to SSE woes (and consequently pulling in WindingNumber code as a dependency).
For now, this is a small change to get compilation going on M1.