Fix 1656 ; Introduce ImGuiPlugin with list of ImGuiWidgets#1973
Merged
alecjacobson merged 1 commit intomainfrom Feb 14, 2022
Merged
Fix 1656 ; Introduce ImGuiPlugin with list of ImGuiWidgets#1973alecjacobson merged 1 commit intomainfrom
alecjacobson merged 1 commit intomainfrom
Conversation
jdumas
approved these changes
Feb 13, 2022
Collaborator
jdumas
left a comment
There was a problem hiding this comment.
Lgtm. When you merge it don't forget to update the changelog on the website.
|
Quick note: The tutorial page still links to #1656 which got resolved here. Don't mean to reopen anything, but I wasn't sure where else to put this. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1656
Following Jeremie's idea #1656 (comment), I've introduced a new "parent"
ImGuiPluginwhich handles ImGui IO functions and converted the oldImGuiMenu,ImGuizmoPlugin,SelectionPluginplugins to inherit from a newImGuiWidgetclass. In this way, a singleImGuiPlugincan be registered to the viewer'spluginslist and one or many widgets are registered to this plugin'swidgetslist.For folks just using the menu, this incurs a few extra lines. To add the menu:
The reward is that now we can use all of these plugins (and any new user created plugins using ImGui subroutines) without conflict.
To highlight this, the updated
109_ImGuizmosuccessfully shows the Viewer menu and the ImGuizmo Widget(since this is a breaking change. I'd love to get it into the upcoming 2.4.0 release)