Skip to content

Update ImGui to v1.85 + use default include folders.#1970

Merged
jdumas merged 1 commit intomainfrom
jdumas/imgui
Feb 11, 2022
Merged

Update ImGui to v1.85 + use default include folders.#1970
jdumas merged 1 commit intomainfrom
jdumas/imgui

Conversation

@jdumas
Copy link
Copy Markdown
Collaborator

@jdumas jdumas commented Feb 11, 2022

Updates CMake code to use the repo imgui and imguizmo as the only include path. This avoids the hack of copying headers around and makes libigl code compatible with other codebase including imgui in their own projects.

Client code using ImGuiMenu.h should not need to include imgui.h (since it's already included by ImGuiMenu.h), but if they do, the following modifications would be required:

  • #include <imgui/imgui.h> --> #include <imgui.h>
  • #include <imgui/imgui_internal.h> --> #include <imgui_internal.h>
  • #include <imgui_impl_glfw.h> --> #include <backends/imgui_impl_glfw.h>
  • #include <imgui_impl_opengl3.h> --> #include <backends/imgui_impl_opengl3.h>

@jdumas jdumas added this to the v2.4.0 milestone Feb 11, 2022
@jdumas jdumas force-pushed the jdumas/imgui branch 5 times, most recently from 1c7b29c to 03694da Compare February 11, 2022 19:34
@jdumas jdumas merged commit 237ffa2 into main Feb 11, 2022
@jdumas jdumas deleted the jdumas/imgui branch February 11, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant