Modified arap interface to accept Eigen::Map#1922
Merged
alecjacobson merged 1 commit intolibigl:mainfrom Dec 20, 2021
Merged
Conversation
Poupine
commented
Nov 20, 2021
alecjacobson
requested changes
Nov 30, 2021
Contributor
alecjacobson
left a comment
There was a problem hiding this comment.
outputs should be plainobjectbase
Contributor
|
Ah, that's a good point. I'd forgotten that arap_solve is actually already
expecting there to be data in U.
I'm OK with this change (adding assertions on the size of U and clarifying
the documentation in the header).
Thanks for pointing that out.
… |
Contributor
Author
|
I believe my latest changes address your comments @alecjacobson |
Contributor
Author
|
Do I need to do anything specific to let GitHub know I've addressed the requested changes? :) |
alecjacobson
approved these changes
Dec 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request implements changes discussed here: #1920
By changing the interface to accept Eigen::MatrixBase instead of Eigen::PlainObjectBase, it becomes possible to pass data to libigl through Eigen::Map-ped data. It allows the user more flexibility in representing mesh data in their code while not requiring unnecessary copies to Eigen matrices, when a Map can be used.
Checklist