Merged
Conversation
jdumas
reviewed
May 26, 2021
cmake/LibiglDownloadExternal.cmake
Outdated
| GIT_REPOSITORY https://github.com/jdumas/tetgen.git | ||
| GIT_TAG c63e7a6434652b8a2065c835bd9d6d298db1a0bc | ||
| GIT_REPOSITORY https://github.com/libigl/tetgen.git | ||
| GIT_TAG 6407f3962d4e24426a81955664391da74e2e2311 |
Collaborator
There was a problem hiding this comment.
Where did you get this SHA1 from? I don't see it in our tetgen mirror.
Contributor
Author
There was a problem hiding this comment.
it's in the v16 branch. The commit hash should be the same when that's merged.
Collaborator
Contributor
Author
Collaborator
|
Oh I didn't see TetGen had a new version 1.6 released in 2020... What a time to live it. Let's merge your 1.6 branch onto the main tetgen branch first then. Then we should update the SHA1 in #1805 directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tetgen commit hash was pointing to the wrong repo. Meanwhile, tetgen has released a new version, now mirrored in https://github.com/libigl/tetgen