Split min_quad_with_fixed implementation into separate cpp.#1746
Merged
Split min_quad_with_fixed implementation into separate cpp.#1746
Conversation
Contributor
|
Maybe we should have a special indicator in the filename for the .cpp that just contain template instantiations. |
Collaborator
Author
I'm using |
Collaborator
Author
|
@alecjacobson I'm gonna merge this one soon, unless you have a strong opinion on the file extension. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly job fails because MSVC runs out of heap space and chokes on
min_quad_with_fixed.cpp. Hopefully by splitting the implementation into separate .cpp this should alleviate the problem.Also, our label Static/HeaderOnly was apparently flipped...