10-100x speedup on per corner normals + caching adjacency#1745
Merged
alecjacobson merged 9 commits intomainfrom Apr 12, 2021
Merged
10-100x speedup on per corner normals + caching adjacency#1745alecjacobson merged 9 commits intomainfrom
alecjacobson merged 9 commits intomainfrom
Conversation
jdumas
reviewed
Mar 8, 2021
Collaborator
jdumas
left a comment
There was a problem hiding this comment.
Nice!
My main recommendation for this PR would be to use stableNormalize() to normalize vectors, otherwise this may introduce NaNs for degenerate facets.
I'd be curious to compare speed with the compute_normal function we have in Lagrange -- it should be pretty optimized.
Contributor
Author
|
#1785 is causing macos to fail. It was passing before and passes locally. I'm moving on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a few flaws in
igl::per_corner_normals. Replaces vector<vector>> style adjacency with serialized adjacency, provides overload with cached adjacency, new function to build this cached adjacency (e.g., at mesh load) so --- for example --- sharp creases/corners are maintained during smooth deformation (compared to rerunning vanilla igl::per_corner_normals which could cause crease-popping). This alone gave good speedups, adding parallel_for moves it into 100x speedup range on my machine.