fix mosek to work with 9.2; fix mosek dynamic link via cmake#1675
Merged
alecjacobson merged 2 commits intomasterfrom Dec 14, 2020
Merged
fix mosek to work with 9.2; fix mosek dynamic link via cmake#1675alecjacobson merged 2 commits intomasterfrom
alecjacobson merged 2 commits intomasterfrom
Conversation
jdumas
requested changes
Dec 13, 2020
Collaborator
jdumas
left a comment
There was a problem hiding this comment.
Honestly I would vote for dropping wrappers for commercial packages (mosek/matlab) from libigl, since we cannot test them in github actions. I have no idea why you need the horrible hack of OSXFixDylibReferences.cmake, and since I don't have access to mosek myself, it'll be difficult to test. In the meantime I'm not sure what we should do with this one.
| # fix mosek | ||
| IF(APPLE) | ||
| INCLUDE(../cmake/OSXFixDylibReferences.cmake) | ||
| OSX_FIX_DYLIB_REFERENCES(libigl_tests "${MOSEK_LIBRARIES}") |
Collaborator
There was a problem hiding this comment.
eeek. this looks like a horrible hack. Do we really need this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think mosek is not in the CI tests. So I guess this will just test whether I mucked up the cmakes (don't think I did).
In the long run we should decide about keeping the mosek wrappers in the library. For now, they might as well work with the current mosek version.