Skip to content

writePLY fix#1673

Merged
jdumas merged 1 commit intolibigl:masterfrom
vfonov:writePLY
Dec 13, 2020
Merged

writePLY fix#1673
jdumas merged 1 commit intolibigl:masterfrom
vfonov:writePLY

Conversation

@vfonov
Copy link
Copy Markdown
Contributor

@vfonov vfonov commented Dec 13, 2020

Fixed a bug in writePLY, when face properties were doubled and edge properties were dropped

Check all that apply (change to [x])

  • All changes meet libigl style-guidelines.
  • Adds new .cpp file.
  • Adds corresponding unit test.
  • This is a minor change.

jdumas
jdumas approved these changes Dec 13, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jdumas jdumas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jdumas jdumas merged commit e6482a8 into libigl:master Dec 13, 2020
@vfonov vfonov deleted the writePLY branch January 5, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdumas jdumas jdumas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vfonov @jdumas