polygon laplacian and other polygon functionality#1653
Merged
alecjacobson merged 6 commits intomasterfrom Dec 22, 2020
Merged
Conversation
Contributor
Author
|
here's a gif for the eventual tutorial so I don't lose it.
|
jdumas
requested changes
Nov 23, 2020
Collaborator
jdumas
left a comment
There was a problem hiding this comment.
Nice addition to libigl!
Some unit tests would be good too (e.g. do we get the same laplacian on a triangle mesh?).
I left a bunch of comments, but most of them is "don't use int" -> we should really be more careful about size conversion and possible loss of precision (large meshes are not gonna fit with 32bit indices).
|
|
||
| // Could at least flip edges of degenerate edges | ||
|
|
||
| //if(pF.rows()>1) |
Collaborator
There was a problem hiding this comment.
We should remove commented code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Polygon Laplacians made Simple using vectorized format for polygons. Other functionality converting to edges, adjacency and triangles for rendering. No tests yet.
Check all that apply (change to
[x])