Offscreen meshes rendering using embree#1652
Conversation
a504d28 to
8ac538d
Compare
… meshes. Using embree (already included in libigl). Addresses libigl#1458, libigl#601 Does not depend on OpenGL. Tutorial example renders `fertility` example with average gaussian curvature field, in 0.1 sec.
8ac538d to
d0f39a3
Compare
jdumas
left a comment
There was a problem hiding this comment.
Hi. This is nice, thanks!
Is there a way to factor out the shared code between EmbreeIntersector and EmbreeRenderer, maybe through a common base class for example?
jdumas
left a comment
There was a problem hiding this comment.
Thanks! But I think there are still some problems with the new EmbreeDevice implementation that you proposed. I've commented on those. Lmk what you think.
jdumas
left a comment
There was a problem hiding this comment.
Hi, sorry about the late review. I think the new singleton class looks good. Too bad we can't use the internal refcounter of the embree device? Anyhow I just have minor comments this time, then we should be good to merge.
|
Merged, thanks! Let me know if you can add a new tutorial entry for the website. |
|
I will try ... |
Added simple raytracing renderer which allows off-screen rendering of meshes
Using embree (already included in libigl). Addresses #1458, #601
Does not depend on OpenGL.
Tutorial example renders
fertilityexample with average gaussian curvature field, in 0.1 sec.Based on
include/igl/embree/EmbreeIntersector.hand examples from embree tutorials.Check all that apply (change to
[x])