You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This also bumps the default simd support for embree from SSE2 to AVX2. Embree's cmake will find all that are compatible but then complains that in static mode we can only select one. I'm guessing most folks using this will have avx2 support (let's see).
@alecjacobson I've rebased onto master so the Windows part should build again. Unit tests are now failing on Linux though, something about the ids in the tree not matching after the update.
I want to try also to set EMBREE_MAX_ISA to DEFAULT. This should pick and enable only one ISA level supported by the compiler, which I think should work on macOS.
All of the unit tests were degenerate examples of rays hitting edges of the cube mesh. So the embree upgrade picked the other face this time and some of them failed. I've pushed a change to make these tests non-degenerate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1632 by updating embree to newest release.
This also bumps the default simd support for embree from SSE2 to AVX2. Embree's cmake will find all that are compatible but then complains that in static mode we can only select one. I'm guessing most folks using this will have avx2 support (let's see).
Check all that apply (change to
[x])