Merged
Conversation
Remove ambiguity (on windows) by using qualified calls everywhere. Remove error with newer version of tinyxml2 which does not have XML_NO_ERROR
Collaborator
|
Wow I didn't know people were still using the DAE writer... |
Contributor
Author
|
Hi, I don't really use it :) It was mainly to test quickly and easily the feature libigl[xml] on vcpkg as I am currently trying to fix some things with the libigl port. The PR was marked as draft until I could see that the CI passed without issue. Since it is the case, I pass it as ready for review. |
Collaborator
|
I don't mind merging this, but just FYI the xml module is not actively used and might even be dropped in the future. |
jdumas
approved these changes
Nov 3, 2020
Contributor
Author
|
No problem, I just did for the sake of completeness. Its future does not concern me anymore 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that apply (change to
[x])