Use new gitlab remote to clone Eigen.#1631
Merged
jdumas merged 1 commit intolibigl:masterfrom Oct 18, 2020
Merged
Conversation
jdumas
approved these changes
Oct 18, 2020
Collaborator
jdumas
left a comment
There was a problem hiding this comment.
Thanks! I think we should stay compatible with Eigen 3.3.7 for a while longer, but at least it should be easy for the user to use a newer version if they want.
Contributor
Author
4 tasks
Collaborator
|
Yeah it's more a question that we should not use newer Eigen features right of the bat, as it might be problematic to integrate into codebases that haven't updated their Eigen version yet. Of course if you're a product using libigl/Eigen you should update if possible, but that part is not up to us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Eigen is now on GitLab.com change path to Eigen's git repository in cmake.
The old github repo is only kept for convenience but does not receive further updates.
Using the repo on gitlab.com it's possible to change to the latest Eigen version 3.3.8 (ChangeLog )
Whether updating to Eigen 3.3.8 is a good idea/worth it or not is another story.
Check all that apply (change to
[x])