Merged
Conversation
jdumas
approved these changes
Sep 21, 2020
Collaborator
jdumas
left a comment
There was a problem hiding this comment.
I'm always supportive of cleaning up deprecated code :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed functions marked with IGL_DEPRECATED.
I don't know whether this is a good idea or not!
#1558 reminded me that quite a while ago someone suggested to keep these functions for one release (which is now v2.2.0) before removing them.
Feel free to close if it's to early.
Check all that apply (change to
[x])