Skip to content

Ear clipping function fix#1565

Merged
alecjacobson merged 3 commits intolibigl:mainfrom
hankstag:ear_clipping_fix
Aug 20, 2023
Merged

Ear clipping function fix#1565
alecjacobson merged 3 commits intolibigl:mainfrom
hankstag:ear_clipping_fix

Conversation

@hankstag
Copy link
Copy Markdown
Collaborator

Fixes #1563 .

[Describe your changes and what you've already done to test it.]

Check all that apply (change to [x])

  • All changes meet libigl style-guidelines.
  • Adds new .cpp file.
  • Adds corresponding unit test.
  • This is a minor change.

@jdumas jdumas requested a review from alecjacobson July 26, 2020 06:10
@alecjacobson
Copy link
Copy Markdown
Contributor

I'm hesitating on this because in the meantime I also coded a fix. I'd like to merge them and take the best option.

Base automatically changed from master to main February 28, 2021 20:33
@alecjacobson alecjacobson merged commit dd38f82 into libigl:main Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

igl::predicates::ear_clipping returns too few triangles

3 participants