Skip to content

SCAF: Expose linear system to be solved by user code#1553

Merged
jdumas merged 4 commits intolibigl:masterfrom
patr-schm:master
Jul 6, 2020
Merged

SCAF: Expose linear system to be solved by user code#1553
jdumas merged 4 commits intolibigl:masterfrom
patr-schm:master

Conversation

@patr-schm
Copy link
Copy Markdown
Contributor

@patr-schm patr-schm commented Jun 26, 2020

I added scaf_system(), which performs the same setup as scaf_solve(), but instead of performing the actual solve and line search, it returns the linear system. Also exposed scaf::compute_energy() in the public interface.

This is useful when the user code optimizes a sum of the SCAF energy and some other energy.

Added a test (scaf.cpp) that calls the new function, performs the solve and line search manually and then compares the result to the original scaf_solve().

Check all that apply (change to [x])

  • All changes meet libigl style-guidelines.
  • Adds new .cpp file.
  • Adds corresponding unit test.
  • This is a minor change.

@jdumas jdumas requested a review from jiangzhongshi July 6, 2020 06:43
Copy link
Copy Markdown
Collaborator

@jiangzhongshi jiangzhongshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice improvement! It does give more flexibility into incorporating ad-hoc linear constraints.

@jdumas jdumas merged commit 015ac35 into libigl:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants