SCAF: Expose linear system to be solved by user code#1553
Merged
jdumas merged 4 commits intolibigl:masterfrom Jul 6, 2020
Merged
SCAF: Expose linear system to be solved by user code#1553jdumas merged 4 commits intolibigl:masterfrom
jdumas merged 4 commits intolibigl:masterfrom
Conversation
jiangzhongshi
approved these changes
Jul 6, 2020
Collaborator
jiangzhongshi
left a comment
There was a problem hiding this comment.
Thanks for the nice improvement! It does give more flexibility into incorporating ad-hoc linear constraints.
jdumas
approved these changes
Jul 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added
scaf_system(), which performs the same setup asscaf_solve(), but instead of performing the actual solve and line search, it returns the linear system. Also exposedscaf::compute_energy()in the public interface.This is useful when the user code optimizes a sum of the SCAF energy and some other energy.
Added a test (
scaf.cpp) that calls the new function, performs the solve and line search manually and then compares the result to the originalscaf_solve().Check all that apply (change to
[x])