Skip to content

Remove duplicate implementation of is_edge_manifold#1509

Merged
alecjacobson merged 2 commits intomasterfrom
is-edge-manifold-refactor
May 8, 2020
Merged

Remove duplicate implementation of is_edge_manifold#1509
alecjacobson merged 2 commits intomasterfrom
is-edge-manifold-refactor

Conversation

@alecjacobson
Copy link
Copy Markdown
Contributor

Just call the (up to 4x) faster one.

Check all that apply (change to [x])

  • All changes meet libigl style-guidelines.
  • Adds new .cpp file.
  • Adds corresponding unit test.
  • This is a minor change.

@alecjacobson
Copy link
Copy Markdown
Contributor Author

How come one test took so much longer?

"Build / Windows (Release, OFF) (pull_request) Successful in 53m"

@alecjacobson alecjacobson merged commit e14a3bd into master May 8, 2020
@jdumas jdumas deleted the is-edge-manifold-refactor branch May 8, 2020 13:03
@jdumas
Copy link
Copy Markdown
Collaborator

jdumas commented May 8, 2020

Hmm most likely previous compilation results where rotated out of the cache system (which has very limited space). That's one of the limitation of the current setup...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants