Bézier curve evaluation and fit cubic Bézier spline to stream of points#1476
Merged
alecjacobson merged 5 commits intomasterfrom Apr 19, 2020
Merged
Bézier curve evaluation and fit cubic Bézier spline to stream of points#1476alecjacobson merged 5 commits intomasterfrom
alecjacobson merged 5 commits intomasterfrom
Conversation
jdumas
reviewed
Apr 14, 2020
| if(nPts==1) { return; } | ||
| // Avoid using zero tangent | ||
| const static auto tangent = [&](const int i,const int dir)->Eigen::RowVectorXd | ||
| const static auto tangent = []( |
Collaborator
There was a problem hiding this comment.
Why do you even need the lambda to be static? It wouldn't make a difference to the compiler.
qnzhou
approved these changes
Apr 19, 2020
Collaborator
qnzhou
left a comment
There was a problem hiding this comment.
Looks good to me! My only concern is that tangent computation seems to be sensitive to input noise.
I am also curious about how good this approach is at capturing sharp corners (G0 locations).
Contributor
Author
|
Both your concerns are very valid and problems with this paper. This can be a reference implementation for now (indeed it's a rewrite from Schneider's gem). It'd be cool to handle those and other issues. Not sure if it's research or there're just better methods out there already. |
|
I wanna know how to use the cubics |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an implementation of "An Algorithm for Automatically Fitting Digitized Curves" by Philip J. Schneider from "Graphics Gems" for arbitrary dimension input (i.e., not just 2D).
Check all that apply (change to
[x])