Allows hsv_to_rgb to work on negative hues#1399
Merged
jdumas merged 1 commit intolibigl:devfrom Jan 4, 2020
Merged
Conversation
… is negative, rather than returning undefined rgb.
jdumas
approved these changes
Jan 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous behavior of hsv_to_rgb is to map positive hue values to the range [0, 360], but does not do the same thing for negative values, instead returning a random result (uninitialized variables). This change causes hsv_to_rgb to always map the input hue to [0, 360].
Closes #1397.
Check all that apply (change to
[x])