Merged
Conversation
Collaborator
Author
|
the two DMAT files in MIQ test data also needs to be updated since the index are changing |
jiangzhongshi
suggested changes
Oct 31, 2019
Collaborator
jiangzhongshi
left a comment
There was a problem hiding this comment.
Nice job overall. This is a very clean implementation for the function. I proposed a few minor changes.
jiangzhongshi
approved these changes
Nov 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Describe your changes and what you've already done to test it.]
Check all that apply (change to
[x])Current implementation of cut_mesh function add duplicated vertices directly after the original one. Breaking the original indices of vertices is undesirable sometimes. This new function will append all new vertices at the bottom of V matrix and provides an index mapping to find the correspondence after cut.
Added some simple unit test. Since the mapping of indices changed, the test data for MIQ needs to be updated.