Skip to content

cut mesh refactor#1332

Merged
hankstag merged 5 commits intolibigl:devfrom
hankstag:pr_cut_mesh
Nov 8, 2019
Merged

cut mesh refactor#1332
hankstag merged 5 commits intolibigl:devfrom
hankstag:pr_cut_mesh

Conversation

@hankstag
Copy link
Copy Markdown
Collaborator

[Describe your changes and what you've already done to test it.]

Check all that apply (change to [x])

  • All changes meet libigl style-guidelines.
  • Adds new .cpp file.
  • Adds corresponding unit test.
  • Adds corresponding python binding.
  • This is a minor change.

Current implementation of cut_mesh function add duplicated vertices directly after the original one. Breaking the original indices of vertices is undesirable sometimes. This new function will append all new vertices at the bottom of V matrix and provides an index mapping to find the correspondence after cut.

Added some simple unit test. Since the mapping of indices changed, the test data for MIQ needs to be updated.

@hankstag
Copy link
Copy Markdown
Collaborator Author

the two DMAT files in MIQ test data also needs to be updated since the index are changing

Copy link
Copy Markdown
Collaborator

@jiangzhongshi jiangzhongshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job overall. This is a very clean implementation for the function. I proposed a few minor changes.

@hankstag hankstag merged commit 911124a into libigl:dev Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants