made list_to_matrix support empty inputs on matrices with static sizes#1309
Merged
alecjacobson merged 9 commits intolibigl:devfrom Oct 10, 2019
Merged
made list_to_matrix support empty inputs on matrices with static sizes#1309alecjacobson merged 9 commits intolibigl:devfrom
alecjacobson merged 9 commits intolibigl:devfrom
Conversation
Update issue_template.md
Version 2.1.0
Collaborator
|
I personally think an assertion failure here should be triggered since you cannot really expect to transform an empty vector into a matrix with random values. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eigen dislikes resizing to (0,0) when a matrix has a static size in some dimension due to an assert.
list_to_matrix now bypasses this assert by checking the RowsAtCompileTime/ColsAtCompileTime and passing in the value that Eigen wants to see.
Check all that apply (change to
[x])