update nrosy to match the MIQ paper#1303
Merged
hankstag merged 2 commits intolibigl:devfrom Oct 22, 2019
Merged
Conversation
Contributor
|
This looks ok, but it does not pass the build. |
jiangzhongshi
approved these changes
Oct 3, 2019
Collaborator
jiangzhongshi
left a comment
There was a problem hiding this comment.
Mostly look ok and the build is TO failing, so I will approve now. But I suggest making a case in the test so that it is clear that nothing is screwed up (so many sign flipping is very error-prone). Also, if possible, it would be best to add some extra comment, referring to the MIQ paper, such that the next person playing around with it won't get as confused as you are today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Describe your changes and what you've already done to test it.]
The current nrosy implementation is not consistent with the MIQ paper, and the singularity index has wrong sign. This PR is to fix this.
Check all that apply (change to
[x])