Merged
Conversation
… with CMAKE_BUILD_TYPE=Debug due to a missing F.maxCoeff()+1 in https://github.com/libigl/libigl/blob/master/include/igl/is_irregular_vertex.cpp#L16
…regular_vertex
jdumas
requested changes
Jul 4, 2019
Collaborator
jdumas
left a comment
There was a problem hiding this comment.
Thanks for the fix! Just got one minor comment.
jdumas
approved these changes
Jul 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only in DEBUG mode Eigen does all boundary checks when accessing elements.
Thus when using
igl::is_irregular_vertex()fails ifCMAKE_BUILD_TYPE=Debug.I've added a test for igl::is_irregular_vertex to showcase that it segfaults with CMAKE_BUILD_TYPE=Debug due to a missing F.maxCoeff()+1 in https://github.com/libigl/libigl/blob/master/include/igl/is_irregular_vertex.cpp#L16 see build https://travis-ci.org/BruegelN/libigl/builds/550519463 (Note only macOS builds with
CMAKE_BUILD_TYPE=Debugand it's not related to the recent changes on Travis CI for macOS)After fixing the off-by-one issue everything works as expected (https://travis-ci.org/BruegelN/libigl/builds/550521102)
Check all that apply (change to
[x])