Merged
Conversation
jdumas
reviewed
Jun 14, 2019
jdumas
requested changes
Jun 14, 2019
Collaborator
jdumas
left a comment
There was a problem hiding this comment.
Can we keep the CMake option LIBIGL_BUILD_PYTHON, and display an error message if the option is set to ON, which points users to this commit, and to the discussion on upcoming python bindings? That would ease the transition for people working off the dev branch until we are ready to merge the new bindings.
danielepanozzo
approved these changes
Jun 15, 2019
Contributor
danielepanozzo
left a comment
There was a problem hiding this comment.
I am in favor of adding a warning message if LIBIGL_BUILD_PYTHON is defined. But even without it the PR is ok for me to merge. Let's try to get this in ASAP since it is slowing down the work on the new python bindings.
…rsect, shape_diameter_function
alecjacobson
approved these changes
Aug 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New cleaned PR or #1162