Skip to content

Fix templating in sort_triangles#1217

Merged
alecjacobson merged 1 commit intodevfrom
sort-triangles
Jun 10, 2019
Merged

Fix templating in sort_triangles#1217
alecjacobson merged 1 commit intodevfrom
sort-triangles

Conversation

@alecjacobson
Copy link
Copy Markdown
Contributor

@alecjacobson alecjacobson commented Jun 7, 2019

PlainObjectBase -> MatrixBase

Check all that apply (change to [x])

  • All changes meet libigl style-guidelines.
  • Adds new .cpp file.
  • Adds corresponding unit test.
  • Adds corresponding python binding.
  • This is a minor change.

@alecjacobson alecjacobson changed the base branch from master to dev June 7, 2019 22:16
@jdumas
Copy link
Copy Markdown
Collaborator

jdumas commented Jun 7, 2019

Pull requests are created against the default branch, which is master ...

@alecjacobson
Copy link
Copy Markdown
Contributor Author

alecjacobson commented Jun 7, 2019

realized that immediately after commenting :- )

@alecjacobson alecjacobson merged commit c27e57e into dev Jun 10, 2019
@jdumas jdumas deleted the sort-triangles branch June 10, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdumas jdumas jdumas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alecjacobson @jdumas