Skip to content

Hunterize libigl#1202

Closed
rbsheth wants to merge 9 commits intolibigl:devfrom
rbsheth:rbsheth_add_hunter
Closed

Hunterize libigl#1202
rbsheth wants to merge 9 commits intolibigl:devfrom
rbsheth:rbsheth_add_hunter

Conversation

@rbsheth
Copy link
Copy Markdown
Contributor

@rbsheth rbsheth commented May 20, 2019

This PR adds basic support for the Hunter package manager in libigl. Because libigl is already following modern CMake practices, the changes needed to make this package Hunter-ready are minimal.

Changes:

  1. Add HunterGate.cmake and corresponding CMake code in CMakeLists.txt
  2. Pull Eigen from Hunter
  3. Add HUNTER_ENABLED flag and default to OFF to preserve current behavior.

Once this change is merged, a new (minor?) GitHub release is needed to generate a source tarball that Hunter can pull in.

Check all that apply (change to [x])

  • All changes meet libigl style-guidelines.
  • Adds new .cpp file.
  • Adds corresponding unit test.
  • Adds corresponding python binding.
  • This is a minor change.

@jdumas jdumas changed the base branch from master to dev May 22, 2019 17:21
@jdumas
Copy link
Copy Markdown
Collaborator

jdumas commented Jun 23, 2019

Hi. Sorry for the delay. PR looks good, and as this doesn't change default behavior I'm ok with merging it. There are some conflicts with the tip of the dev branch though, so if you could solve them and if CI passes I think we can merge it.

@alecjacobson @danielepanozzo I've used Hunter before and it's quite nice. It's a cmake-based package manager. It doesn't cost much to support it for igl::core so I don't see any downside to merging this PR. Let me know if you have any comment.

@danielepanozzo
Copy link
Copy Markdown
Contributor

danielepanozzo commented Jun 24, 2019

I am also ok with it since it does not change the default behavior.

@rbsheth
Copy link
Copy Markdown
Contributor Author

rbsheth commented Jun 25, 2019

Great! @jdumas @danielepanozzo I've updated my branch here: https://github.com/rbsheth/libigl/tree/rbsheth_add_hunter

I think the branch for this PR needs to be re-set to mine (there were some GitHub issues earlier). Here's a comparison of the latest against dev: https://github.com/libigl/libigl/compare/dev...rbsheth:rbsheth_add_hunter?expand=1

@jdumas
Copy link
Copy Markdown
Collaborator

jdumas commented Jun 25, 2019

Hmm I don't think I can do that in the github interface. Probably better if you close this PR and open a clean one against our current dev branch.

@rbsheth rbsheth mentioned this pull request Jun 25, 2019
Merged
5 tasks
@rbsheth
Copy link
Copy Markdown
Contributor Author

rbsheth commented Jun 25, 2019

@jdumas Okay, made a new PR here: #1242

@rbsheth rbsheth closed this Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdumas jdumas jdumas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rbsheth @jdumas @danielepanozzo @alecjacobson