Merged
Conversation
…ase UNIX is not defined under Linux (i.e. Ubuntu). Lowercase unix is defined however. See: https://stackoverflow.com/questions/142508/how-do-i-check-os-with-a-preprocessor-directive Also added missing include for readlink(). readlink() does not append a null byte, thus use information about the written byted when building the resulting string.
…unt that it has a '.exe' suffix.
Contributor
Author
See here for failed test: https://travis-ci.org/libigl/libigl/jobs/532716414#L2191 This issue does somehow not occur with Eigen 3.3. Is there any reason not to switch to Eigen3.3.7 by default? If you want I can submit a PR to make Eigen 3.3 default. @jdumas or who ever can decide this. |
jdumas
approved these changes
Jun 13, 2019
Collaborator
|
We will make Eigen 3.3 the default soon, when we move to the new python bindings. Our deadline for that is a SIGGRAPH course this summer, so it will happen within the next two months =) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added symboles to check for in path_to_executable() because capital case UNIX is not defined under Linux (i.e. Ubuntu).
Lowercase unix is defined however. See: https://stackoverflow.com/questions/142508/how-do-i-check-os-with-a-preprocessor-directive
Also added missing include for readlink().
readlink() does not append a null byte, thus use information about the written byted when building the resulting string.
Check all that apply (change to
[x])