Skip to content

Fix a issue in octree.#1171

Merged
jdumas merged 4 commits intolibigl:devfrom
xarthurx:dev
Apr 27, 2019
Merged

Fix a issue in octree.#1171
jdumas merged 4 commits intolibigl:devfrom
xarthurx:dev

Conversation

@xarthurx
Copy link
Copy Markdown
Contributor

@xarthurx xarthurx commented Apr 21, 2019

For translating centre, the distance should be the half of width of the sub cell instead of the width h.

Check all that apply (change to [x])

  • All changes meet libigl style-guidelines.
  • Adds new .cpp file.
  • Adds corresponding unit test.
  • Adds corresponding python binding.
  • This is a minor change.

X.ZhaoMa and others added 3 commits April 20, 2019 13:12
Merge pull request #2 from libigl/dev
eb65b02 
Merge Dev
Merge remote-tracking branch 'origin/dev' into dev
f14f625
fix issue for octree.
96f825a 
For translating centre, the distance should be the half of width of the sub cell instead of the width h.
@xarthurx
Copy link
Copy Markdown
Contributor Author

xarthurx commented Apr 21, 2019

This request is added due to #1165 (comment).

@xarthurx xarthurx mentioned this pull request Apr 21, 2019
Closed
3 tasks
fwilliams
fwilliams approved these changes Apr 26, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fwilliams fwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jdumas jdumas merged commit fbcb933 into libigl:dev Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fwilliams fwilliams fwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xarthurx @fwilliams @jdumas